Horton

Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Magnus Hagander <magnus@hagander.net>, Michael Banck <michael.banck@credativ.de>, Sergei Kornilov <sk@zsrv.org>
Date: 2019-03-17T09:11:32Z
Lists: pgsql-hackers 
>> I'm not sure that prefixing the two lines with the comment line is very
>> elegant, I'd suggest to put spaces, and would still try to shorten the
>> second sentence, maybe:
>
> I suggest to keep two lines, and only prefix the first one.

As you feel. For me the shorter the better, though, if the information is 
clear and all there.

-- 
Fabien.

Commits

  1. Error out in pg_verify_checksums on incompatible block size

  2. Error out in pg_checksums on incompatible block size