Horton

Re: Offline enabling/disabling of data checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Michael Banck <michael.banck@credativ.de>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-17T17:17:50Z
Lists: pgsql-hackers 
> You have one error at the end of update_controlfile(), where close() 
> could issue a frontend-like error for the backend, calling exit() on the 
> way.  That's not good. (No need to send a new patch, I'll fix it 
> myself.)

Indeed. I meant to merge the "if (close(fd))", but ended merging the error 
generation as well.

-- 
Fabien

Commits

  1. Reorganize Notes section in documentation of pg_checksums

  2. Add option -N/--no-sync to pg_checksums

  3. Add options to enable and disable checksums in pg_checksums

  4. Refactor more code logic to update the control file

  5. Rename pg_verify_checksums to pg_checksums

  6. Fix cross-version compatibility checks of pg_verify_checksums

  7. Add routine able to update the control file to src/common/