Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Bernd Helmle <mailings@oopsware.de>, Michael Paquier <michael@paquier.xyz>, Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-13T06:22:28Z
Lists: pgsql-hackers 
Hallo Michael,

>> I would bother rounding down < 100% to 100, because then you would get
>>
>>    1560/1492 MB (100\%, X MB/s)
>>
>> which is kind of silly.
>
> No, we cap the total_size to current_size so you won't see that (but
> total_size will potentially gradually increase). pg_basebackup has the
> same behaviour.

Ok.

> Because I implemented I/O throttling for pg_checksums

Great!

> New patch attached.

Does not apply because of the renaming committed by Michaël.

Could you rebase?

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums