RE: pgbench - doCustom cleanup
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: "Jamison, Kirk" <k.jamison@jp.fujitsu.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-04T08:40:28Z
Lists: pgsql-hackers
Hello Kirk, > so I tried to apply the patch, but part of the chunk failed, > because of the unused line below which was already removed in the > recent related commit. >> PGResult *res; > I removed the line and fixed the other trailing whitespaces. Indeed. Thanks for the fix. > See the attached latest patch. > The attached patch applies, builds cleanly, > and passes the regression tests. [...] > No problems on my part as I find the changes logical. > This also needs a confirmation from Alvaro. Ok. You switched the patch to "waiting on author": What are you waiting from me? If you think that it is ok and that it should be considered by a committer, probably Alvaro, it can be marked as "ready". -- Fabien.
Commits
-
pgbench: doExecuteCommand -> executeMetaCommand
- 9938d1163310 12.0 landed
-
Rework the pgbench state machine code for clarity
- 3bac77c48f16 12.0 landed
-
instr_time.h: add INSTR_TIME_SET_CURRENT_LAZY
- 6f7d02aa60b7 12.0 landed
-
pgbench: introduce a RandomState struct
- 409231919443 12.0 cited