Horton

Re: get_controlfile() can leak fds in the backend

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, Joe Conway <mail@joeconway.com>
Date: 2019-02-27T09:23:45Z
Lists: pgsql-hackers 
Bonjour Michaël,

> Thoughts?

None.

However, while at it, there is also the question of whether the control 
file should be locked when updated, eg with flock(2) to avoid race 
conditions between concurrent commands. ISTM that there is currently not 
such thing in the code, but that it would be desirable.

-- 
Fabie.

Commits

  1. Tighten use of OpenTransientFile and CloseTransientFile

  2. Make get_controlfile not leak file descriptors