Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-18T08:37:26Z
Lists: pgsql-hackers
> BTW, if you're wondering why curculio is still failing the pgbench > test, Hmmm, that is interesting! It shows that at least some TAP tests are useful. > all is explained here: > > https://man.openbsd.org/srandom > > Or at least most is explained there. Yep. They try to be more serious than other systems about PRNG, which is not bad in itself. > While curculio is unsurprisingly failing all four seeded_random tests, > when I try it locally on an OpenBSD 6.4 installation, only the uniform, > exponential, and gaussian cases reliably "fail". zipfian usually > doesn't. > It looks like the zipfian code almost always produces 4000 regardless of > the seed value, though occasionally it produces 4001. Bad parameters > for that algorithm, perhaps? Welcome to the zipfian highly skewed distribution! I'll check the parameters used in the test, maybe it should use something less extreme. srandom is only used for initializing the state of various internal rand48 LCG PRNG for pgbench. Maybe on OpenBSD pg should switch srandom to srandom_deterministic? -- Fabien.
Commits
-
Fix portability problem in pgbench.
- e6c3ba7fbfd5 12.0 landed
- 27d6bc68f98e 11.2 landed
-
Avoid assuming that we know the spelling of getopt_long's error messages.
- 434040159558 11.2 landed
- 251f57460f12 12.0 landed