Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Bernd Helmle <bernd.helmle@credativ.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2018-12-25T11:12:43Z
Lists: pgsql-hackers 
> Given the speed of verifying checksums and its storage-oriented status, I 
> also still think that a (possibly fractional) MB (1,000,000 bytes), or even 
> GB, is the right unit to use for reporting this progress. On my laptop (SSD), 
> verifying runs at least at 1.26 GB/s (on one small test), there is no point 
> in displaying kilobytes progress.

Obviously the file is cached by the system at such speed, but still most 
disks should provides dozens of MB per second of read bandwidth. If GB is 
used, it should use fractional display (eg 1.25 GB) though.

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums