Horton

Re: Progress reporting for pg_verify_checksums

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Banck <michael.banck@credativ.de>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Bernd Helmle <bernd.helmle@credativ.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2018-12-25T18:05:30Z
Lists: pgsql-hackers 
> I think MB indeed makes more sense than kB, so I have changed that now 
> in V7, per attached.

You use 1024² bytes. What about 1000000 bytes per MB, as the unit is about 
stored files?

Also, you did not answer to my other points:
  - use "instr_time.h" for better precision
  - invert sizeonly
  - reuse a test

-- 
Fabien.

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums