Re: fix psql \conninfo & \connect when using hostaddr

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Arthur Zakirov <a.zakirov@postgrespro.ru>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-11-19T19:43:12Z
Lists: pgsql-hackers
Hello Alvaro,

>>  - libpq internal function getHostaddr get a length,
>>    and I added an assert about it.
>>  - added a few braces on if/if/else/if/else/else
>>  - added an UNKNOWN_HOST macro to hide "???"
>>  - moved host_addr[] declaration earlier to avoid some braces
>
> You forgot to free(conn->connip) during freePGconn().

Argh, indeed:-(

> I found the UNKNOWN_HOST business quite dubious -- not only in your
> patch but also in the existing coding.

So did I:-) I only kept it because it was already done like that.

> I changed the getHostname API so that instead of returning "???" it sets 
> the output buffer to the empty string.

I hesitated to do exactly that. I'm fine with that.

Thanks for the push.

-- 
Fabien.


Commits

  1. Tweak libpq's PQhost, PQhostaddr, and psql's \connect

  2. psql: Show IP address in \conninfo