Re: Conflicting option checking in pg_restore

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2018-10-29T06:11:35Z
Lists: pgsql-hackers
Hallå Daniel,

> an assertion?

v2 applies, compiles, both local & global make check are ok.

Its CF category could have been "bug fix" or "restructuring".

> [...] Perhaps, we don’t really test for all other potential 
> misconfigurations of the options so I can go either way.  It’s also a 
> cheap enough operation.  Do you think it should be a check like today or

Michaël suggests that there is no issue of external tool using the 
internal function, so I'm fine with this version.

I have switched the patch to ready for committer.

-- 
Fabien.

Commits

  1. Consolidate cross-option checks in pg_restore

  2. Throw an error when using -C and -1 at the same time in pg_restore.