Re: pgbench - add pseudo-random permutation function

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Hironobu SUZUKI <hironobu@interdb.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-10-25T06:21:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgbench: Function to generate random permutations.
- 6b258e3d688d 14.0 landed
Add basic support for using the POPCNT and SSE4.2s LZCNT opcodes
- 711bab1e4d19 12.0 cited
Further improve code for probing the availability of ARM CRC instructions.
- a7a7387575b8 11.0 cited

Attachments

pgbench-prp-func-12.patch (text/x-diff) patch

Hello Alvaro,

>> although not comment changes which break the logic of the algorithm
>> descriptions. I have not found how to tell pgindent to let comments
>> indentation alone.
>
> You can use /*----- for such comments.

Thanks for the hint. Here is an updated patch using this marker.

I noticed that some instances use a closing "*-----" sequence, but it does 
not seem useful, so I left it out.

I have also tried to improve a few comments, and moved a declaration into 
a loop because I did not like the pg-indented version much.

-- 
Fabien.