Re: pgbench - add pseudo-random permutation function

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Hironobu SUZUKI <hironobu@interdb.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-10-24T20:43:02Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pgbench: Function to generate random permutations.
- 6b258e3d688d 14.0 landed
Add basic support for using the POPCNT and SSE4.2s LZCNT opcodes
- 711bab1e4d19 12.0 cited
Further improve code for probing the availability of ARM CRC instructions.
- a7a7387575b8 11.0 cited

Attachments

pgbench-prp-func-11.patch (text/x-diff) patch

Hello Alvaro,

> Can you please pgindent this?

Hmmm. After some investigation, I installed some "pg_bsd_indent" and ran 
the "pgindent" script, which reindented far more than the patch... So I 
picked up the patch-related changes and integrated them manually, although 
not comment changes which break the logic of the algorithm descriptions. I 
have not found how to tell pgindent to let comments indentation alone.

Here is the result for the code, and for part of comments.

-- 
Fabien.