Horton

Re: [HACKERS] pgbench - allow to store select results into variables

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Stephen Frost <sfrost@snowman.net>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2018-10-02T06:43:04Z
Lists: pgsql-hackers

Attachments

Bonjour Michaël,

> On Tue, Aug 14, 2018 at 01:38:21PM +0200, Fabien COELHO wrote:
>> I re-attached the v19 for a check on the list.
>
> You are marked as the committer of this patch in the CF app since last
> April and this patch is marked as ready for committer.  Are you planning
> to look at it soon?

Here is yet another rebase.

Whether Stephen will have time to commit this patch is unclear. I'd 
suggest that I remove his name from the committer column so that another 
committer may consider it.

What do you think?

For me this patch is fundamental because it allows a test script to 
interact both ways with the database, and to act on database data (in 
particular thanks to \if and expressions already added), and also actually 
retrieving results is a key benchmark compliance constraint that pgbench 
does not meet.

-- 
Fabien.

Commits

  1. pgbench: Remove \cset

  2. pgbench: add \cset and \gset commands

  3. Adjust pgbench to allow non-ASCII characters in variable names.

  4. Refactor script execution state machine in pgbench.

  5. Allow empty queries in pgbench.