Horton

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, "Rady, Doug" <radydoug@amazon.com>, Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-09-15T13:59:08Z
Lists: pgsql-hackers

Attachments

>> The author hasn't replied, but the attached seems to have cured the 
>> bitrot so that it at least applies. Let's see what the cfbot makes of 
>> it and then possibly fix any Windows issues.

The patch was not applying cleanly anymore for me, so here is a rebase of 
your latest version.

Morever, ISTM that Tom's "why?" question has been answered: there are very 
large systems out there with many processors, which are tested against 
many connections, exceeding select limit.

I have turned back this patch to ready.

-- 
Fabien.

Commits

  1. Use ppoll(2), if available, to wait for input in pgbench.

  2. Use pselect(2) not select(2), if available, to wait in postmaster's loop.