Re: [HACKERS] pgbench - allow to store select results into variables

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2018-08-14T20:44:16Z
Lists: pgsql-hackers
>> I have no doubt that some MUA around would forget to do the conversion.
>
> FWIW, one reason that I invariably use patch(1) to apply submitted patches
> is that it will take care of stripping any CRs that may have snuck in.
> So I'm not particularly fussed about the problem.

Good to know.

> I'm not excited about encouraging people to use application/octet-stream
> rather than text/something for submitted patches.

I'm not happy with that either, it is just to avoid complaints.

> If you use text then the patch can easily be examined in the web 
> archives; with application/octet-stream the patch has to be downloaded, 
> adding a lot of manual overhead.

Indeed.

>  (At least, that's true with my preferred web browser, maybe it's 
> different for other people?)

So if I send with text/x-diff or text/plain I've got complaints, if I send 
with application/octet-stream, it is not right either:-) Everybody being 
somehow right.

Sigh.

-- 
Fabien.


Commits

  1. pgbench: Remove \cset

  2. pgbench: add \cset and \gset commands

  3. Adjust pgbench to allow non-ASCII characters in variable names.

  4. Refactor script execution state machine in pgbench.

  5. Allow empty queries in pgbench.