Horton

Re: libpq should not look up all host addresses at once

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-08-11T12:15:44Z
Lists: pgsql-hackers 
> * when the password is required, there is no way to know for which host/ip it 
> is:
>
> sh> psql "host=127.0.0.17,local2.coelho.net,local.coelho.net"
> Password for user fabien:

In the same vein on a wrong password:

  sh> psql "host=no-such-host,local2.coelho.net,local3.coelho.net"
  Password for user fabien:
  psql: could not translate host name "no-such-host" to address: Name or service not known
  could not connect to server: Connection refused
         Is the server running on host "local2.coelho.net" (127.0.0.2) and accepting
         TCP/IP connections on port 5432?
  could not connect to server: Connection refused
         Is the server running on host "local2.coelho.net" (127.0.0.3) and accepting
         TCP/IP connections on port 5432?
  FATAL:  password authentication failed for user "fabien"

The Fatal error does not really say for which host/ip the password fail.

Basically, with multiple hostnames and ips per hostname, error messages
need to be more precise.

-- 
Fabien.

Commits

  1. In libpq, don't look up all the hostnames at once.