Re: pgbench's expression parsing & negative numbers
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-08-10T08:24:29Z
Lists: pgsql-hackers
Attachments
- pgbench-overflow-4.patch (text/plain) patch
Hello, > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: not tested > > Patch does not apply cleanly on the master branch, anyways I managed that. Patch work according to specs, and no issue found. > The only minor nit is that you can keep the full comments of function strtoint64 > > /* > * If not errorOK, an error message is printed out. > * If errorOK is true, just return "false" for bad input. > */ Thanks for the review. Attached is a v4, with improved comments on strtoint64 as you requested. I also added 2 "unlikely" compiler directives. -- Fabien.
Commits
-
Correct overflow handling in pgbench.
- 92a0342a90b3 12.0 landed