pgbench - very minor bug fix on hash() missing argument
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-07-27T03:16:06Z
Lists: pgsql-hackers
Attachments
- pgbench-hash-nargs-1.patch (text/plain) patch
While doing something else, I noticed that pgbench's hash() does not fail
gracefully:
sh> cat hash.sql
\set i hash()
sh> pgbench -f hash.sql -t 1
...
cannot coerce (null) to int
client 0 aborted in command 0 (set) of script 0; evaluation of meta-command failed
The message is not very helful. With the attached one-line patch plus
test, it is clearer:
sh> pgbench -f hash.sql -t 1
hash.sql:1: unexpected number of arguments (hash) in command "set"
\set i hash()
^ error found here
Could be backpatched to 11 where hash was introduced.
--
Fabien.
Commits
-
Fix handling of pgbench's hash when no argument is provided
- c2e5f60db160 11.0 landed
- 39d51fe87dae 12.0 landed