Horton

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: "Rady, Doug" <radydoug@amazon.com>
Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-03-27T09:06:33Z
Lists: pgsql-hackers 
Hello Doug,

>> I've compiled and run with both ppoll & select options without issues. 
>> Two quite minor style comment (at least 2 instances):

> Fixed. Fixed. Also fixed issue with 'timeout' not being passed as NULL 
> when no timeout time.

v12 compiled and tested with both ppoll & select (by forcing). All seems 
ok to me.

Switched back to "ready".

-- 
Fabien.

Commits

  1. Use ppoll(2), if available, to wait for input in pgbench.

  2. Use pselect(2) not select(2), if available, to wait in postmaster's loop.