Re: pgbench - add \if support
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2018-03-21T18:10:23Z
Lists: pgsql-hackers
Attachments
- pgbench-if-7.patch (text/plain) patch
Hello Teodor, > Patch seems usefull and commitable except comments in conditional.[ch]. I'd > like to top/header comment in each file more detailed and descriptive. As for > now it mentions only psql usage without explaining how it is basic or common. Indeed, it was not updated. I've fixed the file names and added a simple description at the beginning of the header file, and a one liner in the code file. Do you think that more is needed? The patch also needed a rebase after the hash function addition. -- Fabien.
Commits
-
Add \if support to pgbench
- f67b113ac627 11.0 landed