Horton

Re: [HACKERS] pgbench - allow to store select results into variables

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, Tatsuo Ishii <ishii@sraoss.co.jp>, rafia.sabih@enterprisedb.com, Tom Lane <tgl@sss.pgh.pa.us>, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-12-01T05:48:10Z
Lists: pgsql-hackers 
Hello Michaël,

>> Here is a v14, after yet another rebase, and some comments added to answer
>> your new comments.
>
> The last patch sent still applies, but its status of "ready for
> committer" does not look adapted as this version got no reviews. So I
> am switching back the patch as "needs review". Feel free to change if
> that's not adapted,

Indeed, I think that is not needed, as the edit was beyond mundane 
(comments lightly edited, one const added after a wind of const got 
committed, patch context diff changes probably after a pgindent run that 
triggered the need of a rebase), which is why I did not updated the status 
for this version.

So I put it back to "ready".

> The patch is moved as well to next CF.

-- 
Fabien.

Commits

  1. pgbench: Remove \cset

  2. pgbench: add \cset and \gset commands

  3. Adjust pgbench to allow non-ASCII characters in variable names.

  4. Refactor script execution state machine in pgbench.

  5. Allow empty queries in pgbench.