Horton

Re: [HACKERS] [WIP] Zipfian distribution in pgbench

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Alik Khilazhev <a.khilazhev@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-11-20T16:09:11Z
Lists: pgsql-hackers 
Hello Alik,

Patch applies, compiles, works (I checked the distribution). Doc gen ok. 
make check ok.

> I have reduced range to [1, 10] and updated the test.

I would suggest to use [1, 9] and the simpler regex [1-9] instead of the 
full list.

Also, there should be an empty line between functions. I just noticed that 
one is missing after zipfFindOrCreateCacheCell().

-- 
Fabien.

Commits

  1. Add approximated Zipfian-distributed random generator to pgbench.