Horton

Re: pgbench tap tests & minor fixes.

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nikolay Shaplov <dhyan@nataraj.su>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-09-04T23:05:09Z
Lists: pgsql-hackers

Attachments

> Anyway, done with the addition of a "chomp" parameter, leaving only the 
> TAP test changes to consider.

Ok, thanks.

> I'll set the CF entry back to "waiting on author" pending your
> revisions of those.

See attached.

Removed scalar/array ref hack, plenty [] added everywhere to match.

Removed perl function prototypes.

Does not try to announce the number of tests, just tell when done.

-- 
Fabien.

Commits

  1. Add much-more-extensive TAP tests for pgbench.

  2. Be more careful about newline-chomping in pgbench.

  3. Fix some subtle problems in pgbench transaction stats counting.