Re: Variable substitution in psql backtick expansion
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
Pavel Stehule <pavel.stehule@gmail.com>,
Corey Huinker <corey.huinker@gmail.com>,
Daniel Verite <daniel@manitou-mail.org>,
PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-09-04T20:41:03Z
Lists: pgsql-hackers
> I think we should go with Daniel's idea for all three parts. I'm okay with that, although probably it should be an independent patch. >> In the documentation, I do not think that both SERVER_VERSION_NAME and >> _NUM (or whatever their chosen name) deserve two independent explanations >> with heavy repeats just one after the other, and being treated differently >> from VERSION_*. > > I started with it that way, but it seemed pretty unreadable with the > parenthetical examples added. And I think we need the examples, > particularly the one pointing out that you might get something like "beta". Yes for "beta" which is also in the v8 patch I sent. One shared doc with different examples does not look too bad to me, and having things repeated so closely do not look good. >> Seeing it as is, it calls for having "SERVER_VERSION" as well, but I'm not >> sure of the better way to get it. I tried with "SELECT VERSION() AS >> SERVER_VERSION \gset" but varnames are lowerized. > > The problem there is you can't get version() without an extra round trip > to the server --- and an extra logged query --- which people are going to > complain about. Yep. -- Fabien.
Commits
-
Add psql variables showing server version and psql version.
- a6c678f018d3 10.0 landed
- 9ae9d8c1549c 11.0 landed
-
Reformat psql's --help=variables output.
- 3955c8c4eda2 11.0 landed
-
Remove reinvention of stringify macro.
- cd6baed78150 10.0 landed
-
Allow psql variable substitution to occur in backtick command strings.
- f833c847b8fa 10.0 landed