Re: Confusing error message in pgbench
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-08-02T15:26:24Z
Lists: pgsql-hackers
Attachments
- pgbench-query-mode-error-2.patch (text/x-diff) patch
Hello Tatsuo-san, > I found an error message in pgbench is quite confusing. > > pgbench -S -M extended -c 1 -T 30 test > query mode (-M) should be specified before any transaction scripts (-f or -b) > > Since there's no -f or -b option is specified, users will be > confused. Indeed. > Actually the error occurs because pgbench implicitly introduces a built > in script for -S. To eliminate the confusion, I think the error message > should be fixed like this: The idea is that -S/-N documentations say that it is just a shortcut for -b, but the explanation (eg --help) is too far away. > query mode (-M) should be specified before transaction type (-S or -N) > or any transaction scripts (-f or -b) I would suggest to make it even shorter, see attached: query mode (-M) should be specified before any transaction scripts (-f, -b, -S or -N). I'm wondering whether it could/should be "any transaction script". My English level does not allow to decide. -- Fabien.
Commits
-
Remove pgbench's restriction on placement of -M switch.
- 79681844297a 10.0 landed