Horton

Re: pgbench tap tests & minor fixes

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2017-06-15T19:10:12Z
Lists: pgsql-hackers

Attachments

> As for me, I would do expr_scanner_chomp_substring(PsqlScanState, int, int&);
> that changes end_offset as desired...

Why not.

> And use it instead of end_offset = expr_scanner_offset(sstate) - 1;

I removed these?

> The second issue: you are removing all trailing \n and \r. I think you should
> remove only one \n at the end of the string, and one \r before \n if there was
> one.

So chomp one eol.

Is the attached version better to your test?

-- 
Fabien.

Commits

  1. Add much-more-extensive TAP tests for pgbench.

  2. Be more careful about newline-chomping in pgbench.

  3. Fix some subtle problems in pgbench transaction stats counting.