Horton

Re: pgbench tap tests & minor fixes

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-04-24T07:01:18Z
Lists: pgsql-hackers

Attachments

> To sum up:
>
> - I agree to add a generic command TestLib & a wrapper in PostgresNode,
>   instead of having pgbench specific things in the later, then call
>   them from pgbench test script.
>
> - I still think that moving the pgbench scripts inside the test script
>   is a bad idea (tm).

Here is a v2 along those lines.

I have also separated some basic test which do not need a server running, 
as done in other tap tests.

-- 
Fabien.

Commits

  1. Add much-more-extensive TAP tests for pgbench.

  2. Be more careful about newline-chomping in pgbench.

  3. Fix some subtle problems in pgbench transaction stats counting.