Re: pgbench - allow to store select results into variables

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>

To: Tatsuo Ishii <ishii@sraoss.co.jp>

Cc: tgl@sss.pgh.pa.us, rafia.sabih@enterprisedb.com, michael.paquier@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, pavel.stehule@gmail.com, PostgreSQL Developers <pgsql-hackers@postgresql.org>

Date: 2017-04-17T06:34:53Z

Lists: pgsql-hackers

Attachments

pgbench-utf8-vars-2.patch (text/x-diff) patch

Hello Tatsuo-san,

> Thank you for the patch. I tested a little bit and found that it does
> not allow value replacement against non ascii variables in given SQL
> statements . Is it intentional?

No, this is a bug.

> If not, I think you need to fix parseVariable() as well.

Indeed. Here is v2.

-- 
Fabien.

Commits

pgbench: Remove \cset
- 25ee70511ec2 12.0 landed
pgbench: add \cset and \gset commands
- 6260cc550b0e 12.0 landed
Adjust pgbench to allow non-ASCII characters in variable names.
- 9d36a386608d 11.0 landed
Refactor script execution state machine in pgbench.
- 12788ae49e19 10.0 cited
Allow empty queries in pgbench.
- 6471045230f5 10.0 cited