Horton

Thread

Commits

  1. Doc: remove duplicate index entry.

  1. duplicate "median" entry in doc

    Fabien COELHO <coelho@cri.ensmp.fr> — 2017-02-16T15:24:34Z

    When trying to build the documentation there is a minor warning:

   collateindex.pl: duplicated index entry found: MEDIAN

Indeed, the "median" index term is specified twice in "syntax.sgml". The 
attached patch removes the warning.

-- 
Fabien.

  2. Re: duplicate "median" entry in doc

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-02-16T15:35:40Z

    Fabien COELHO <coelho@cri.ensmp.fr> writes:
> When trying to build the documentation there is a minor warning:
>    collateindex.pl: duplicated index entry found: MEDIAN

See
https://www.postgresql.org/message-id/29262.1483053514@sss.pgh.pa.us

I've been waiting for some clarification on that before attempting
to fix this.  In any case, your proposed patch would remove the main
index entry, which doesn't seem like what we want.

			regards, tom lane

  3. Re: duplicate "median" entry in doc

    Fabien COELHO <coelho@cri.ensmp.fr> — 2017-02-16T16:06:03Z

    >> When trying to build the documentation there is a minor warning:
>>    collateindex.pl: duplicated index entry found: MEDIAN
>
> See
> https://www.postgresql.org/message-id/29262.1483053514@sss.pgh.pa.us
>
> I've been waiting for some clarification on that before attempting
> to fix this.  In any case, your proposed patch would remove the main
> index entry, which doesn't seem like what we want.

Hmmm. I do not get it.

I confirm that "oldhtml" does not generate the "see also" in head, 
probably because the first termindex/primary is kept and overrides the 
second somehow, which is consistent with the warning.

However, after removing the duplicate, both "oldhtml" (openjade 1.3, 
issues with 1.4) and "html" (xsltproc) generate a correct "median" index 
with its "see also" subsection, in "bookindex.html":

   ...
   MD5, Password Authentication
   median, Aggregate Expressions
       (see also percentile)
   memory context
   ...

So this really seems ok to me... The only difference is that with the new 
chain the percentile is a link and there are parentheses, while with 
oldhtml it is just text.

Am I missing something?

-- 
Fabien.

  4. Re: duplicate "median" entry in doc

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-02-16T16:32:19Z

    Fabien COELHO <coelho@cri.ensmp.fr> writes:
> I confirm that "oldhtml" does not generate the "see also" in head, 
> probably because the first termindex/primary is kept and overrides the 
> second somehow, which is consistent with the warning.

> However, after removing the duplicate, both "oldhtml" (openjade 1.3, 
> issues with 1.4) and "html" (xsltproc) generate a correct "median" index 
> with its "see also" subsection, in "bookindex.html":

[ scratches head... ]  Coulda sworn I tried that and it didn't do what
I wanted.  But testing now, it does, so pushed.  Thanks for pointing
out my error.

			regards, tom lane

  5. Re: duplicate "median" entry in doc

    Fabien COELHO <coelho@cri.ensmp.fr> — 2017-02-16T17:45:57Z

    > [ scratches head... ]

Magic:-)

While testing with "oldhtml" I found that the "maintainer-clean" targets 
in "sgml" does not clean enough: it lacks cleaning the "oldhtml-stamp".

See attached very minor fix.

-- 
Fabien.

  6. oldhtml-stamp (was Re: duplicate "median" entry in doc)

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-02-16T18:41:06Z

    Fabien COELHO <coelho@cri.ensmp.fr> writes:
> While testing with "oldhtml" I found that the "maintainer-clean" targets 
> in "sgml" does not clean enough: it lacks cleaning the "oldhtml-stamp".

Yeah, and .gitignore fails to ignore it, too.  I'm not sure if it's
worth fixing ... Peter, what's the expected half-life of the "oldhtml"
target?

			regards, tom lane