Re: pgbench - allow backslash continuations in \set expressions

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Rafia Sabih <rafia.sabih@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-01-13T11:27:57Z
Lists: pgsql-hackers
Hello Rafia,

>>   sh> git apply ~/pgbench-continuation-3.patch
>>   # ok
>
> It still gives me whitespace errors with git apply,

Strange.

> /Users/edb/Downloads/pgbench-continuation-3.patch:31: trailing whitespace.
> continuation \\{newline}

> Looks like an editor issue, I used awk '{ sub("\r$", ""); print }'
> patch1 > patch2 to clean it and it was applying then.

Doing that does not change the file for me.

I see no \r in the patch file according to "od", I just see "nl" (0x0a).

sha1sum: 97fe805a89707565210699694467f9256ca02dab pgbench-continuation-3.patch

Could it be related to transformations operated when the file is 
downloaded and saved, because it is a text file?

-- 
Fabien.


Commits

  1. Allow backslash line continuations in pgbench's meta commands.