Horton

Re: BUG: pg_stat_statements query normalization issues with combined queries

Fabien COELHO <coelho@cri.ensmp.fr>

View thread View on postgr.es
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, craig.ringer@2ndquadrant.com, robertmhaas@gmail.com, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-01-12T19:02:10Z
Lists: pgsql-hackers 
> [...] it seems a lot cleaner to me.

I agree.

> [...] It's safe in backend-legal encodings.

Good:-)

> [...] The trouble for statements like EXPLAIN is that we replace the 
> sub-statement during parse analysis, [...]

Ok. So Node* is fine to keep it generic.

-- 
Fabien.

Commits

  1. Teach contrib/pg_stat_statements to handle multi-statement commands better.

  2. Change representation of statement lists, and add statement location info.

  3. Revert my bad decision of about a year ago to make PortalDefineQuery