Re: pgbench - allow to store select results into variables
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2016-07-09T12:52:51Z
Lists: pgsql-hackers
>> Also a more subjective argument: I do not like the gset automagic naming >> feature. I got more inspired by PL/pgSQL and ECPG which both have an "into" >> syntax with explicit variable names that let nothing to guessing. I like >> things to be simple and explicit, hence the proposed into. > > the gset was originally designed differently - but now it is here - and it > is not practical to have two different, but pretty similar statements in > psql and pgbench. In my view they are unrelated: on the one hand "gset" is really an interactive feature, where typing is costly so "automagic" might make sense; on the other hand "into" is a scripting feature, where you want to understand the code and have something as readable as possible, without surprises. The commands are named differently and behave differently. If someone thinks that "gset" is a good idea for pgbench, which I don't, it could be implemented. I think that an "into" feature, like PL/pgSQL & ECPG, makes more sense for scripting. -- Fabien.
Commits
-
pgbench: Remove \cset
- 25ee70511ec2 12.0 landed
-
pgbench: add \cset and \gset commands
- 6260cc550b0e 12.0 landed
-
Adjust pgbench to allow non-ASCII characters in variable names.
- 9d36a386608d 11.0 landed
-
Refactor script execution state machine in pgbench.
- 12788ae49e19 10.0 cited
-
Allow empty queries in pgbench.
- 6471045230f5 10.0 cited