Horton

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

Steve Singer <steve@ssinger.info>

View thread View on postgr.es
From: Steve Singer <steve@ssinger.info>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Masahiko Sawada <sawada.mshk@gmail.com>, Jose Luis Tallon <jltallon@adv-solutions.net>
Date: 2019-11-24T01:10:51Z
Lists: pgsql-hackers 
On Wed, 20 Nov 2019, Alexey Kondratov wrote:

> Hi Steve,
>
> Thank you for review.


I've looked through the patch and tested it.
I don't see any issues with this version. I think it is ready for a 
committer.


>
> Regards
>
> -- 
> Alexey Kondratov
>
> Postgres Professional https://www.postgrespro.com
> Russian Postgres Company
>
> P.S. I have also added all previous thread participants to CC in order to do 
> not split the thread. Sorry if it was a bad idea.
>

Steve

Commits

  1. Add TABLESPACE option to REINDEX

  2. Refactor code in tablecmds.c to check and process tablespace moves

  3. Refactor option handling of CLUSTER, REINDEX and VACUUM

  4. pg_dump: Don't use enums for defining bit mask values

  5. Refactor CLUSTER and REINDEX grammar to use DefElem for option lists

  6. Refactor parsing rules for option lists of EXPLAIN, VACUUM and ANALYZE

  7. Improve tab completion of REINDEX in psql

  8. Fix possible crash during FATAL exit from reindexing.