Re: pgbench stats per script & other stuff

Fabien COELHO <coelho@cri.ensmp.fr>

From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-01-27T15:21:16Z
Lists: pgsql-hackers

Attachments

Hello again,

>> Obviously this would work. I did not think the special case was worth the
>> extra argument. This one has some oddity too, because the second argument is
>> ignored depending on the third. Do as you feel.
>
> Actually my question was whether keeping the original start_time was the
> intended design.

Sorry I misunderstood the question.

The answer is essentially yes, the field is needed for the "aggregated" 
mode where this specific behavior is used.

However, after some look at the code I think that it is possible to do 
without.

I also spotted an small issue under low tps where the last aggregation was 
not shown.

With the attached version these problems have been removed, no conditional 
initialization. There is also a small diff with the version you sent.

-- 
Fabien.

Commits

  1. pgbench: Allow changing weights for scripts