Horton

Re: [Review] Re: minor patch submission: CREATE CAST ... AS EXPLICIT

Fabien COELHO <coelho@cri.ensmp.fr>

View thread
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Cédric Villemain <cedric@2ndquadrant.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>, Jeff Janes <jeff.janes@gmail.com>, Heikki Linnakangas <hlinnakangas@vmware.com>
Date: 2013-06-24T09:44:21Z
Lists: pgsql-hackers

Attachments

>> Here it is.
>
> The patch does not apply and git also whines about trailing space.
> It needs a v3...

The attachement here works for me.
Could you be more precise about the issue?

  postgresql> git branch test master
  postgresql> git checkout test
  Switched to branch 'test'
  postgresql> patch -p1 < ../as_explicit-v2.patch
  patching file doc/src/sgml/ref/create_cast.sgml
  patching file src/backend/parser/gram.y
  patching file src/include/parser/kwlist.h
  patching file src/test/regress/expected/create_cast.out
  patching file src/test/regress/sql/create_cast.sql

> Please note that a community-agreed behavior on this patch is not yet
> acquired, you should consider that too.

Sure. I've sent my argumentation against Robert objections.

-- 
Fabien.