Horton
Menu

Re: Add some regression tests for SEQUENCE

Fabien COELHO <coelho@cri.ensmp.fr>

View thread
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Robins Tharakan <tharakan@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-05-08T07:55:07Z
Lists: pgsql-hackers 
> Have provided an updated patch as per Fabien's recent response on 
> Commitfest site. Any and all feedback is appreciated.

Review:

This patch works for me.

It adds valuable sequence test cases, especially trying corner cases with 
expected errors and permission denials.

I suggest to accept it.

-- 
Fabien.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Allow CREATE FOREIGN TABLE to include SERIAL columns.