Re: [PATCH] Make "psql -1 < file.sql" work as with "-f"
Fabien COELHO <coelho@cri.ensmp.fr>
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Fetter <david@fetter.org>, PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2012-08-09T16:08:21Z
Lists: pgsql-hackers
> OK, done. > > I had to revise the original patch pretty heavily before committing; > the original patch assumed that it was OK to make psql -1 <file go > through process_file() while having psql -1 <file still go through > MainLoop() directly. This isn't a good idea, because that means that > any other behavioral differences between process_file() and MainLoop() > will be contingent on whether -1 is used, which is not what we want. Yep. I did that with a "smallest" and "simplest" change in mind, and beside when doing "psql -1 < file", you're hardly going to do anything else anyway, so I felt that it was not a big issue. > And there is at least one such difference that matters: whether or not > the file and line number get prepended when emitting error messages. Thanks for the improvements and for the push! -- Fabien.