Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge

Jeremy Drake <pgsql@jdrake.com>

From: Jeremy Drake <pgsql@jdrake.com>

To: Bruce Momjian <bruce@momjian.us>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@postgresql.org

Date: 2011-09-02T06:48:31Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove unnecessary #include references, per pgrminclude script.
- 6416a82a62db 9.2.0 cited
Remove "fmgr.h" include in cube contrib --- caused crash on a Gentoo
- d5321842528d 9.2.0 cited
Allow more include files to be compiled in their own by adding missing
- 4bd7333b1478 9.2.0 cited
Add support for #elif to pgrminclude.
- d010391ac8f7 9.2.0 cited

On Thu, 1 Sep 2011, Bruce Momjian wrote:

> Jeremy Drake wrote:
>
> > I am the owner of both mongoose and okapi.  Let me know if there's
> > anything you want me to try.
>
> Thanks.  I would either like to email you patches to test or get ssh
> access so I can compile it myself.

You can send me patches if you want, but I spent a little time with it
tonight and it seems to be the change to src/include/access/xlog.h:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blobdiff;f=src/include/access/xlog.h;h=1fd60fb98d7362b677112517a20a41e32227a34f;hp=cdbf63fa76e0e7b154c084191d0df6138e1cbfcc;hb=4bd7333;hpb=d010391ac8f706e17998671534ca1230f68d2f38

Unfortunately, I also had to revert commit
6416a82a62db4e66b2edb0fa8fc83a580c3f1931 to fix compile errors.  I expect
you would be able to do something a little more surgical than that...