Re: [HACKERS] Trouble with COPY IN

Kris Jurka <books@ejurka.com>

From: Kris Jurka <books@ejurka.com>

To: James William Pye <lists@jwp.name>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org, Matthew Wakeling <matthew@flymine.org>, Kevin Grittner <Kevin.Grittner@wicourts.gov>, Maciek Sakrejda <msakrejda@truviso.com>, Samuel Gendler <sgendler@ideasculptor.com>, pgsql-jdbc@postgresql.org

Date: 2010-08-06T23:31:45Z

Lists: pgsql-hackers

Attachments

binary-copy-end-v2.patch (text/plain) patch v2

On Wed, 28 Jul 2010, James William Pye wrote:

> Not directly regarding your patch, but while the discussion is in the 
> general area. I think it would be wise to throw an error when non-empty 
> CopyData messages are received after CopyData(EOF). Chances are that the 
> user is making a mistake and should be notified of it.
>

As this is also the direction that Tom Lane indicated we should go, here 
is a patch which errors out after receiving any more copy data past the 
EOF marker.  This also fixes the protocol problem I previously brought up 
because the act of checking to see if there is any more data does ensure 
that if there isn't any more data in the current buffer, that we wait for 
the client to provide CopyDone/Fail.

Kris Jurka