Horton

Thread

Commits

  1. Add infrastructure to support server-version-dependent tab completion.

  1. remove VersionedQuery support from psql tab completion

    Nathan Bossart <nathandbossart@gmail.com> — 2026-07-02T18:51:26Z

    This infrastructure was added by commit 722408bcd1 and was only ever used
for publications and subscriptions.  Since we just bumped psql's minimum
supported version to v10, it's no longer used by anything.  Furthermore, a
quick glance indicates there's nothing else that should use it.  So, IMHO
we might as well remove it.

-- 
nathan

  2. Re: remove VersionedQuery support from psql tab completion

    Ayush Tiwari <ayushtiwari.slg01@gmail.com> — 2026-07-02T19:44:24Z

    Hi,

On Fri, 3 Jul 2026 at 00:21, Nathan Bossart <nathandbossart@gmail.com>
wrote:

> This infrastructure was added by commit 722408bcd1 and was only ever used
> for publications and subscriptions.  Since we just bumped psql's minimum
> supported version to v10, it's no longer used by anything.  Furthermore, a
> quick glance indicates there's nothing else that should use it.  So, IMHO
> we might as well remove it.
>

Thanks for the patch!

Doing a grep on VersionedQuery I could find one instance missing
in your patch in 010_tab_completion.pl file there's a test block

# check VersionedQuery infrastructure
check_completion(
    "DROP PUBLIC\t \t\t",
    qr/DROP PUBLICATION\s+some_publication /,
    "check VersionedQuery");

I think the test case is fine, but the comment + label needs to be
updated or case drop if it's redundant.

Rest, LGTM.

Regards,
Ayush

  3. Re: remove VersionedQuery support from psql tab completion

    Tom Lane <tgl@sss.pgh.pa.us> — 2026-07-02T22:17:38Z

    Nathan Bossart <nathandbossart@gmail.com> writes:
> This infrastructure was added by commit 722408bcd1 and was only ever used
> for publications and subscriptions.  Since we just bumped psql's minimum
> supported version to v10, it's no longer used by anything.  Furthermore, a
> quick glance indicates there's nothing else that should use it.  So, IMHO
> we might as well remove it.

This seems a little short-sighted.  Do you think we'll never again
make any catalog changes that affect tab completion?  Admittedly,
maybe all such cases will fall under what SchemaQuery is good for.
But that's significantly harder to use, so I'm not really in a
hurry to make that tradeoff.

			regards, tom lane

  4. Re: remove VersionedQuery support from psql tab completion

    Nathan Bossart <nathandbossart@gmail.com> — 2026-07-06T14:12:58Z

    On Thu, Jul 02, 2026 at 06:17:38PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> This infrastructure was added by commit 722408bcd1 and was only ever used
>> for publications and subscriptions.  Since we just bumped psql's minimum
>> supported version to v10, it's no longer used by anything.  Furthermore, a
>> quick glance indicates there's nothing else that should use it.  So, IMHO
>> we might as well remove it.
> 
> This seems a little short-sighted.  Do you think we'll never again
> make any catalog changes that affect tab completion?  Admittedly,
> maybe all such cases will fall under what SchemaQuery is good for.
> But that's significantly harder to use, so I'm not really in a
> hurry to make that tradeoff.

That's what I thought at first, but given we didn't accumulate any other
uses in the ~8 years it was around, I think there's a reasonably good
chance it goes unused for quite a while longer.  This was just a small bit
of cleanup; I'm fine with leaving it around if you want.

-- 
nathan