Horton

Re: Fix jsonpath .decimal() to honor silent mode

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Ewan Young <kdbase.hack@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Chao Li <li.evan.chao@gmail.com>
Date: 2026-07-01T10:31:39Z
Lists: pgsql-hackers 
On Wed, Jul 01, 2026 at 03:52:51PM +0800, Ewan Young wrote:
> If reviewers would rather push the ErrorSaveContext down into
> numerictypmodin() (or a shared helper)
> instead of pre-validating in the caller, I'm happy to reshape it that way.

My first impression while looking at your patch and the surroundings
of numeric.c is that we should do exactly that, and feed from the
error message received from the new function to which an escontext is
given.  That would save in extra error messages (why not just reuse
the same errstrings in this case?), and we could rely on
error_occurred for the detection.
--
Michael

Commits

  1. Fix redefinition of typedef Node in numeric.h

  2. Fix jsonpath .decimal() to honor silent mode