Horton

Re: statatt_build_stavalues->LOCAL_FCINFO wrong number

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-06-29T23:32:30Z
Lists: pgsql-hackers 
On Mon, Jun 29, 2026 at 07:13:07PM +0800, jian he wrote:
> "elemtypid" does not appear within the function (mentioned above), so
> "elemtypid" comment is wrong?

Nice catch.  These comments missed a refresh when this code has been
reworked.  I have bundled that in the patch, while on it.

> The general idea is to add a trailing comma to the last field of each enum.
> We need to add a comma after the last field in enum attribute_stats_argnum,
> clear_attribute_stats_argnum, and extended_stats_exprs_element.

I didn't see a strong need in this one, though..
--
Michael

Commits

  1. Simplify some stats restore code with InputFunctionCallSafe()

  2. Move attribute statistics functions to stat_utils.c