Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: JoongHyuk Shin <sjh910805@gmail.com>, Zsolt Parragi <zsolt.parragi@percona.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-07-08T01:43:53Z
Lists: pgsql-hackers
On Wed, Jul 08, 2026 at 10:38:54AM +0900, Fujii Masao wrote: > We can remove assign_recovery_target_name()? With the v8 patch, it only > assigns the GUC string pointer to recoveryTargetName. It seems we could > instead have recovery_target_name store its value directly in > recoveryTargetName, remove recovery_target_name_string, and drop > the assign hook altogether. Thoughts? Yeah, perhaps we should just do that. I've also found the consistency with all these _string variables interesting to keep, but that's minor compared to less code. -- Michael