Re: [PATCH] Warn when io_min_workers exceeds io_max_workers
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Tristan Partin <tristan@partin.io>
Cc: Baji Shaik <baji.pgdev@gmail.com>, PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-23T01:29:35Z
Lists: pgsql-hackers
On Mon, Jun 22, 2026 at 10:30:10PM +0000, Tristan Partin wrote: > The code looks good. I wonder if we should add a test. I could not find > a similar test for autovacuum for what it's worth. Hmm, okay. Why not warning in this case, with a message showing up only once in the worker with ID=0 at startup and reload. Let's adjust the messages so as the GUC parameters are included as %s in the error strings, and apply the same thing for the autovacuum path. A benefit is that we are then able to reduce the translation work churn with only one message to translate for both. Hence, I'd suggest to reword the error messages of both as of: "\"%s\" (%d) should be less than or equal to \"%s\" (%d)", "guc_max_min", min_val, "guc_min_name", max_val -- Michael
Commits
-
Use placeholders and not GUC names in error message (autovacuum)
- 7905416eef9b master landed