Horton

Re: BUG #19520: PANIC when concurrently manipulating stored procedures with pg_stat_statements and track_functions =

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, zlh21343@163.com, pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2026-06-20T07:43:52Z
Lists: pgsql-bugs 
On Thu, Jun 18, 2026 at 02:40:46PM +0900, Michael Paquier wrote:
> On Thu, Jun 18, 2026 at 08:52:49AM +0530, Ayush Tiwari wrote:
>> The v2 patch looks fine to me. Tested it, no PANICs.
> 
> The buildfarm has backfired with the ABI compliance check, which has
> made me double-check for some extension code where the API change
> would matter, based on this list:
> https://wiki.postgresql.org/wiki/CustomCumulativeStats

Another thing I have forgotten to mention regarding 850b9218c8e4..
I have tweaked the patch so as we still show the refcount and the
generation in the error message, something that was missed in the
latest version of the patch posted on this thread.  This information
is useful for debugging purposes.
--
Michael

Commits

  1. Re-introduce pgstat_drop_entry(), keeping ABI compatibility

  2. Update .abi-compliance-history for pgstat_drop_entry()

  3. Fix PANIC with track_functions due to concurrent drop of pgstats entries