Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

Álvaro Herrera <alvherre@kurilemu.de>

View thread View on postgr.es
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>, Tatsuo Ishii <ishii@postgresql.org>, jian.universality@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-06-18T14:46:14Z
Lists: pgsql-hackers 
Hello,

I would dearly appreciate it if you could make these errors in this
style:

ereport(ERROR,
        (errcode(ERRCODE_WRONG_OBJECT_TYPE),
        /* translator: first %s is a CREATE FUNCTION clause, eg. "IGNORE NULLS" */
         errmsg("%s specified, but %s is not a window function",
         "RESPECT/IGNORE NULLS", NameListToString(funcname)),
         parser_errposition(pstate, location)));

to avoid keeping the clause name in the translatable string.

Thanks

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Entristecido, Wutra                     (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.