Re: Redundant/mis-use of _(x) gettext macro?
Álvaro Herrera <alvherre@kurilemu.de>
From: Álvaro Herrera <alvherre@kurilemu.de>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-11T16:44:45Z
Lists: pgsql-hackers
Attachments
- 0001-fix-some-psql-strings.patch (text/x-diff)
On 2026-Apr-24, Peter Smith wrote: > OK. Including the comma within a larger translated string seems like a > better idea. [...] > Also, why did you choose to implement `last` versus `first` logic? > e.g. How about this? In the end I decided to go with the flow and changed to use "first" logic rather than "last". I also figured that we should change the other two places you pointed out at the start of the thread to use the same coding style. Since this is mostly cosmetic, I don't feel compelled to back-patch it, and pushed only to master. Another place I noticed while looking this over is psql's describeOneTableDetails(), per the attached patch. It's essentially more of the same, but arguably different enough that I judged it warranted posting before pushing. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix translatable string construction in psql
- 5459223edb1d 19 (unreleased) landed
-
Fix translatable string construction
- 3692a622d3fd 19 (unreleased) landed