Re: Do quoting more carefully in replication commands

Álvaro Herrera <alvherre@kurilemu.de>

From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2026-06-12T21:02:05Z
Lists: pgsql-hackers
On 2026-Jun-12, Tom Lane wrote:

> (I envision back-patching this all the way, but have not yet
> looked at whether the back branches will require adjustments.)

In a quick skim, I wondered about this bit:

> + * Caution: this quoting logic is sufficient for identifiers and literals
> + * in the replication grammar, but not always in regular SQL.  Specifically,
> + * it'd fail for a string literal if standard_conforming_strings is off.

... given that standard_conforming_strings can no longer be off in 19.
The backpatched version should surely still have this, just in case, but
in 19 it's probably not needed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"After a quick R of TFM, all I can say is HOLY CR** THAT IS COOL! PostgreSQL was
amazing when I first started using it at 7.2, and I'm continually astounded by
learning new features and techniques made available by the continuing work of
the development team."
Berend Tober, http://archives.postgresql.org/pgsql-hackers/2007-08/msg01009.php



Commits

  1. Clean up quoting of variable strings within replication commands.