Horton

Thread

Commits

  1. pg_dump: Remove dead code in TAP tests

  1. Dead reference to schema_only_with_statistics in pg_dump TAP code

    Michael Paquier <michael@paquier.xyz> — 2026-06-15T08:07:45Z

    Hi all,

While looking at the TAP tests of pg_dump today, I have bumped into a
dead reference to a command sequence named schema_only_with_statistics.
This reference has been removed in 0ed92cf50cc4, and has been listed a
couple of times after that, having no effect.

Let's clean up that as of the attached on HEAD, at least.  v18 would
be nice to include in the set, as this script is already complicated
and that could create noise when backpatching.

Comments or opinions?
--
Michael

  2. Re: Dead reference to schema_only_with_statistics in pg_dump TAP code

    Ewan Young <kdbase.hack@gmail.com> — 2026-06-15T10:04:59Z

    Hi Michael,

Confirmed here. The schema_only_with_statistics run definition was
removed in 0ed92cf50cc4 (when --schema-only + --with-statistics became
a rejected combination), but the references left behind in %full_runs
and in the per-test like/unlike lists were never cleaned up. Since the
main loop only iterates over keys %pgdump_runs, those leftover keys are
never looked up, so they've simply been inert.

LGTM, and +1 for including v18 to keep future back-patches quiet.

Thanks,
Ewan

On Mon, Jun 15, 2026 at 4:07 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> Hi all,
>
> While looking at the TAP tests of pg_dump today, I have bumped into a
> dead reference to a command sequence named schema_only_with_statistics.
> This reference has been removed in 0ed92cf50cc4, and has been listed a
> couple of times after that, having no effect.
>
> Let's clean up that as of the attached on HEAD, at least.  v18 would
> be nice to include in the set, as this script is already complicated
> and that could create noise when backpatching.
>
> Comments or opinions?
> --
> Michael

  3. Re: Dead reference to schema_only_with_statistics in pg_dump TAP code

    Michael Paquier <michael@paquier.xyz> — 2026-06-15T23:36:26Z

    On Mon, Jun 15, 2026 at 06:04:59PM +0800, Ewan Young wrote:
> LGTM, and +1 for including v18 to keep future back-patches quiet.

Ok, thanks.  Applied now as I have been playing with this area of the
code.
--
Michael