Horton

Re: Use \if/\endif to remove non-libxml2 expected output in regression tests

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-15T00:49:21Z
Lists: pgsql-hackers

Attachments

On Sun, Jun 14, 2026 at 07:33:54PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Positioning the \if after the three initial INSERT queries (\if query
>> that counts the number of tuples inserted), like in the patch I have
>> posted upthread, is able to hit NO_XML_SUPPORT() in xmlin().  That
>> would be enough.  Would you agree with that?
> 
> Works for me.

Okay.  So fusioning my stuff, your stuff and Daniel's comment
suggestion, I get the attached.  That's working here with my system's
libxml2 (2.12.10), libxml2 2.9.3 and without libxml2.

Does that look right?  
--
Michael

Commits

  1. Trim regression test expected output for xml

  2. Add an expected-file to match behavior of latest libxml2.